convert between integer and byte array #103

flier · 2019-02-28T10:41:07Z

After Rust 1.32, the function to_<endian>_bytes and from_<endian>_bytes has stabilizations.

Cargo.toml

build.rs

src/int.rs

flier · 2019-03-05T06:58:32Z

Tests seem crashed at src/int.rs - int::PrimInt::unsigned_shr (line 173)

---- src/int.rs - int::PrimInt::unsigned_shr (line 173) stdout ----
error: literal out of range for i64
 --> src/int.rs:176:9
  |
6 | let n = 0xFEDCBA9876543210i64;
  |         ^^^^^^^^^^^^^^^^^^^^^ help: consider using `u64` instead: `0xFEDCBA9876543210u64`
  |
  = note: #[deny(overflowing_literals)] on by default
  = note: the literal `0xFEDCBA9876543210i64` (decimal `18364758544493064720`) does not fit into an `i64` and will become `-81985529216486896i64`
thread 'src/int.rs - int::PrimInt::unsigned_shr (line 173)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:351:13
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

erikbrinkman · 2021-03-02T22:06:21Z

The PR seems to have gone fallow, but if you come back to it, it'd be great to extend this to the float types as they also got these methods in 1.40.

flier · 2021-03-04T04:07:32Z

Hi @erikbrinkman and @cuviper

The PR has be updated

The trait has been renamed to ToFromBytes
Use autocfg to check the expression
Implements ToFromBytes for integer and float

cuviper

With Bytes implemented so generically, this could also support types like BigUint using Vec<u8>. Consuming self is not desirable in that case, so maybe the trait should use &self in the to_ methods? And likewise for from_, should they take &Self::Bytes? I expect the references would also get optimized away for the primitive cases anyway.

We do need to drop the breaking changes to existing traits. I would also like to see unit tests that cover each of the implemented primitive types.

cuviper · 2021-04-09T22:30:47Z

src/float.rs


 #[cfg(all(not(feature = "std"), feature = "libm"))]
 use libm;

 /// Generic trait for floating point numbers that works with `no_std`.
 ///
 /// This trait implements a subset of the `Float` trait.
-pub trait FloatCore: Num + NumCast + Neg<Output = Self> + PartialOrd + Copy {
+pub trait FloatCore: Num + NumCast + Neg<Output = Self> + PartialOrd + Copy + ToFromBytes {


It's a breaking change to add requirements to the existing traits. ToFromBytes will have to stand alone.

cuviper · 2021-04-09T22:31:10Z

src/int.rs

@@ -51,6 +51,7 @@ pub trait PrimInt:
    + CheckedMul<Output = Self>
    + CheckedDiv<Output = Self>
    + Saturating
+    + ToFromBytes


Also a breaking change.

Co-authored-by: Flier Lu <flier.lu@gmail.com>

cuviper · 2023-02-10T22:46:11Z

Sorry, I pushed to this branch on accident, but the revived development is in #224.

224: Convert between int and bytes #189 r=cuviper a=kaidokert Picking up #103 from `@flier` to rebase and factor in feedback. Making a quick draft first Co-authored-by: Kaido Kert <kaidokert@gmail.com> Co-authored-by: Josh Stone <cuviper@gmail.com> Co-authored-by: kaidokert <kaidokert@gmail.com>

cuviper requested changes Feb 28, 2019

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

build.rs Outdated Show resolved Hide resolved

src/int.rs Outdated Show resolved Hide resolved

cuviper mentioned this pull request Oct 3, 2020

PrimInt: to_be_bytes & co #189

Closed

cuviper reviewed Apr 9, 2021

View reviewed changes

flier force-pushed the convert_between_int_and_bytes branch from 498f7d8 to fe7d50d Compare April 19, 2021 02:08

kaidokert mentioned this pull request Oct 17, 2021

Convert between int and bytes #189 #224

Merged

kaidokert and others added 2 commits February 10, 2023 14:25

Convert between int and bytes

2f2a463

Co-authored-by: Flier Lu <flier.lu@gmail.com>

Simplify float to/from_bytes and enable tests

a922693

cuviper force-pushed the convert_between_int_and_bytes branch from efa9f80 to a922693 Compare February 10, 2023 22:25

cuviper closed this Feb 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convert between integer and byte array #103

convert between integer and byte array #103

flier commented Feb 28, 2019 •

edited

flier commented Mar 5, 2019

erikbrinkman commented Mar 2, 2021

flier commented Mar 4, 2021

cuviper left a comment

cuviper Apr 9, 2021

cuviper Apr 9, 2021

cuviper commented Feb 10, 2023

convert between integer and byte array #103

convert between integer and byte array #103

Conversation

flier commented Feb 28, 2019 • edited

flier commented Mar 5, 2019

erikbrinkman commented Mar 2, 2021

flier commented Mar 4, 2021

cuviper left a comment

Choose a reason for hiding this comment

cuviper Apr 9, 2021

Choose a reason for hiding this comment

cuviper Apr 9, 2021

Choose a reason for hiding this comment

cuviper commented Feb 10, 2023

flier commented Feb 28, 2019 •

edited